From pablojr at gmail.com Mon Dec 20 15:39:04 2010 From: pablojr at gmail.com (Pablo Rogina) Date: Mon, 20 Dec 2010 11:39:04 -0300 Subject: [dff-devel] Adding a new translation (Spanish) to DFF Message-ID: Hi, following the instructions from recent commit regarding issue #84, I prepared the Spanish translation (basically a new Dff_es.ts file and a modified CMakeLists.txt file) so I'm ready to commit. Being this my first contribution to the project, do I go directly and "git push" to origin/master or do I sent a patch to somebody for review before commit? Anyway, this is work in progress and it's just the starting point for full translation-aware. I've just detected some dialogs that aren't translatable at all (i.e. available devices to add) so this is going to take several steps until we could consider it done. Thanks, Pablo -------------- next part -------------- An HTML attachment was scrubbed... URL: From fba at arxsys.fr Mon Dec 20 17:24:34 2010 From: fba at arxsys.fr (=?ISO-8859-1?Q?Fr=E9d=E9ric_Baguelin?=) Date: Mon, 20 Dec 2010 16:24:34 +0000 Subject: [dff-devel] Adding a new translation (Spanish) to DFF In-Reply-To: References: Message-ID: <4D0F8342.6090705@arxsys.fr> Hi Pablo, I suggest you to continue working in your branch at the moment and provide us a patch. We will review it and if everything is fine, will merge in the master. I'm going to write how to proceed when contributing and share it through the Wiki. At the moment, developers work in their own branch. When the feature is considered stable, we merge it in the master branch. Thanks a lot for your contrib. It's really appreciated ! Fred Pablo Rogina wrote: > Hi, > > following the instructions from recent commit regarding issue #84, I > prepared the Spanish translation (basically a new Dff_es.ts file and a > modified CMakeLists.txt file) so I'm ready to commit. > Being this my first contribution to the project, do I go directly and > "git push" to origin/master or do I sent a patch to somebody for review > before commit? > > Anyway, this is work in progress and it's just the starting point for > full translation-aware. I've just detected some dialogs that aren't > translatable at all (i.e. available devices to add) so this is going to > take several steps until we could consider it done. > > Thanks, > > Pablo > > > ------------------------------------------------------------------------ > > _______________________________________________ > dff-devel mailing list > dff-devel at digital-forensic.org > http://lists.digital-forensic.org/listinfo/dff-devel -- Fr?d?ric Baguelin frederic.baguelin at arxsys.fr ArxSys SAS, Directeur technique T?l: +33 1 40 13 53 44 Fax: +33 1 40 13 53 01 From pablojr at gmail.com Sat Dec 25 19:23:57 2010 From: pablojr at gmail.com (Pablo Rogina) Date: Sat, 25 Dec 2010 15:23:57 -0300 Subject: [dff-devel] DDF Spanish - first two patchs Message-ID: Hi, please find attached compressed patch for my two commit about Spanish translations. First one is the initial translation of Dff_es.ts file, created based on instructions from commit about issue #84. Then I went along and also changed Select Device dialog (it appears when Add device(s) option is selected). This changed led to the other translation files changed as well (since new strings were found). I didn't translate the French file (I cannot do it...) but I'm including the .ts files in the patch. I also tried to modify the Modules option in main window, but I'll comment about that in a separate mail... Thanks, Pablo. -------------- next part -------------- A non-text attachment was scrubbed... Name: spanish_translation.tgz Type: application/x-gzip Size: 5679 bytes Desc: not available URL: From pablojr at gmail.com Sat Dec 25 19:33:36 2010 From: pablojr at gmail.com (Pablo Rogina) Date: Sat, 25 Dec 2010 15:33:36 -0300 Subject: [dff-devel] Translations: missing tr() in menu Modules Message-ID: Hi, After finishing first step of adding Spanish translation (by translating the new created Dff_es.ts file) it turned out that the Modules entry didn't translate. I guess this went unnoticed for French people since Modules (en) = Modules (fr) [Thank you Google]. But it's not the case in Spanish (M?dulos). So I tried to dig into Python files to see if I can add the missing tr() entries. I changed ui/gui/mainwindow.py to add: #menu self.menuList = [[self.tr("File"), ["New_Dump", "New_Device", "Exit"]], [self.tr("Modules"), ["Load"]], ] but while testing again, error shown as: File "/home/pablo/projects/dff/build/ui/gui/utils/menu.py", line 38, in Load self.listMenuAction.append(self.parent.menu["Modules"].addMenu(MenuModules(self.parent, self.mainWindow, tags, self.selectItem))) KeyError: 'Modules' so I then changed that file this way (in 4 different lines): self.parent.menu[QApplication.translate("MenuTags", "Modules")].connect(self.parent.menu[QApplication.translate("MenuTags", "Modules")], SIGNAL("aboutToShow()"), self.refreshQMenuModules) but on runtime I've got this error File "/home/pablo/projects/dff/build/ui/gui/utils/menu.py", line 39, in Load self.listMenuAction.append(self.parent.menu[QApplication.translate("MenuTags", "Modules")].addMenu(MenuModules(self.parent, self.mainWindow, tags, self.selectItem))) KeyError: PyQt4.QtCore.QString(u'Modules') so I stopped since my PtQt knowledge is limited and unfortunately the translation stuff is proving harder than I imagined... If somebody could guide meon an easy path to change this, that's welcomed... Thanks. From pablojr at gmail.com Sat Dec 25 20:49:41 2010 From: pablojr at gmail.com (Pablo Rogina) Date: Sat, 25 Dec 2010 16:49:41 -0300 Subject: [dff-devel] Behavior of "Select Device" dialog Message-ID: Hi, what's the intended behavior of dialog that appears when selecting option "Add device(s)" from File menu? Should the user be able to select just one device? Or mark several devices from the table and when clicking OK all the selected devices be added as nodes? I ask since currently the table in the dialog allows to select more than one device but when click OK just one device is added to node browser. Thanks. Pablo From solal.jacob at ArxSys.fr Sun Dec 26 17:07:29 2010 From: solal.jacob at ArxSys.fr (Solal Jacob) Date: Sun, 26 Dec 2010 16:07:29 +0000 Subject: [dff-devel] Behavior of "Select Device" dialog In-Reply-To: References: Message-ID: <4D176841.9060306@ArxSys.fr> Hi, Thanks for the report, the devices dialog permit only to select one devices to be added as nodes. We must modify that, one of the contributor have already said he will modify that window, to permit to select only one devices and also to select all the lines and not just one of 'box' in the tables. I will ask him if he do the change and to commit the results. Thanks Solal. On 12/25/10 19:49, Pablo Rogina wrote: > Hi, > > what's the intended behavior of dialog that appears when selecting > option "Add device(s)" from File menu? > > Should the user be able to select just one device? Or mark several > devices from the table and when clicking OK all the selected devices > be added as nodes? > > I ask since currently the table in the dialog allows to select more > than one device but when click OK just one device is added to node > browser. > > Thanks. > > Pablo > _______________________________________________ > dff-devel mailing list > dff-devel at digital-forensic.org > http://lists.digital-forensic.org/listinfo/dff-devel From solal.jacob at ArxSys.fr Sun Dec 26 17:11:49 2010 From: solal.jacob at ArxSys.fr (Solal Jacob) Date: Sun, 26 Dec 2010 16:11:49 +0000 Subject: [dff-devel] Translations: missing tr() in menu Modules In-Reply-To: References: Message-ID: <4D176945.4000302@ArxSys.fr> Hi Pablo, Christophe as starting to re-integrat the translation it's not finish yet but we will look at this bug, it's seems we use the keyword 'modules' in a hash table to get the list of availables modules, so it certainly not found the key once translated. I know that Christophe and most of the core team are in vacation until January so I don't know if this will be patched soon. Thanks for the report. On 12/25/10 18:33, Pablo Rogina wrote: > Hi, > > After finishing first step of adding Spanish translation (by > translating the new created Dff_es.ts file) it turned out that the > Modules entry didn't translate. I guess this went unnoticed for French > people since Modules (en) = Modules (fr) [Thank you Google]. > > But it's not the case in Spanish (M?dulos). So I tried to dig into > Python files to see if I can add the missing tr() entries. > > I changed ui/gui/mainwindow.py to add: > > #menu > self.menuList = [[self.tr("File"), ["New_Dump", "New_Device", "Exit"]], > [self.tr("Modules"), ["Load"]], > ] > > but while testing again, error shown as: > > File "/home/pablo/projects/dff/build/ui/gui/utils/menu.py", line 38, in Load > self.listMenuAction.append(self.parent.menu["Modules"].addMenu(MenuModules(self.parent, > self.mainWindow, tags, self.selectItem))) > KeyError: 'Modules' > > so I then changed that file this way (in 4 different lines): > > self.parent.menu[QApplication.translate("MenuTags", > "Modules")].connect(self.parent.menu[QApplication.translate("MenuTags", > "Modules")], SIGNAL("aboutToShow()"), self.refreshQMenuModules) > > but on runtime I've got this error > > File "/home/pablo/projects/dff/build/ui/gui/utils/menu.py", line 39, in Load > self.listMenuAction.append(self.parent.menu[QApplication.translate("MenuTags", > "Modules")].addMenu(MenuModules(self.parent, self.mainWindow, tags, > self.selectItem))) > KeyError: PyQt4.QtCore.QString(u'Modules') > > so I stopped since my PtQt knowledge is limited and unfortunately the > translation stuff is proving harder than I imagined... > > If somebody could guide meon an easy path to change this, that's welcomed... > > Thanks. > _______________________________________________ > dff-devel mailing list > dff-devel at digital-forensic.org > http://lists.digital-forensic.org/listinfo/dff-devel > -- Solal Jacob solal.jacob at arxsys.fr ArxSys, Riposte Num?rique 5, Rue d'Uz?s 75002 Paris T?l: +33 1 40 13 53 44 Fax: +33 1 40 13 53 01 www.arxsys.fr www.digital-forensic.org From fba at arxsys.fr Sun Dec 26 18:55:10 2010 From: fba at arxsys.fr (=?ISO-8859-1?Q?Fr=E9d=E9ric_Baguelin?=) Date: Sun, 26 Dec 2010 17:55:10 +0000 Subject: [dff-devel] Behavior of "Select Device" dialog In-Reply-To: References: Message-ID: <4D17817E.6090002@arxsys.fr> Indeed, this behaviour is a bit strange... It will be taken into account for the next release. Thanks, Pablo Rogina wrote: > Hi, > > what's the intended behavior of dialog that appears when selecting > option "Add device(s)" from File menu? > > Should the user be able to select just one device? Or mark several > devices from the table and when clicking OK all the selected devices > be added as nodes? > > I ask since currently the table in the dialog allows to select more > than one device but when click OK just one device is added to node > browser. > > Thanks. > > Pablo > _______________________________________________ > dff-devel mailing list > dff-devel at digital-forensic.org > http://lists.digital-forensic.org/listinfo/dff-devel -- Fr?d?ric Baguelin frederic.baguelin at arxsys.fr ArxSys SAS, Directeur technique T?l: +33 1 40 13 53 44 Fax: +33 1 40 13 53 01 From pablojr at gmail.com Tue Dec 28 00:27:31 2010 From: pablojr at gmail.com (Pablo Rogina) Date: Mon, 27 Dec 2010 20:27:31 -0300 Subject: [dff-devel] Patch to avoid changing About string every time application version is changed Message-ID: Hi, please find attached patch to avoid changing the About string every time the application version is changed. It uses %1 and arg() method from tr() to dynamically replace text inside the translated string. Thanks, Pablo -------------- next part -------------- A non-text attachment was scrubbed... Name: 0003-Changed-About-string-to-include-version-number-as-ar.patch Type: text/x-patch Size: 11640 bytes Desc: not available URL: